Rework connect types and add type test setup #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `connect` to use the entire `Connect` overload config - Fixed declaration of `wrapWithConnect` - Fixed a bunch of weird problems in the type tests file with actions, dispatch, etc - used `ts-expect-error for actual intended failures
|
Size Change: +1 kB (5%) 🔍 Total Size: 20.1 kB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 299824e:
|
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 299824e 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60e8dcd8c6e3040008f466ae 😎 Browse the preview: https://deploy-preview-1766--react-redux-docs.netlify.app |
markerikson
force-pushed
the
feature/ts-type-tests
branch
from
1c34305 to
299824e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@types/react-reduxDT package as a starting pointconnectandconnectAdvancedtypes to actually have the right function overloadsConnectedProps<T>type, and makes sure it's exportedPer #1737