Connected component prevents all context propagations

[rpominov]

Because connected components have aggressive shouldComponentUpdate, and shouldComponentUpdate doesn't support context, connected components basically stop any other context variables changes to propagate to their children.

Is there a recommended solution to this problem? I found pure option (connect(..., {pure: false})), which helps, but is there a better way?

[esamattis]

Related facebook/react#2517

[rpominov]

One possible solution to this is to check only state in shouldComponentUpdate, if state didn't change always return true, and allow target component to decide if it should be updated.

This seems like a reasonable default behavior to me — check in shouldComponentUpdate only stuff we manage (this.state), and delegate any other checks to user's components.

[gaearon]

The only better option that using { pure: false } if you rely on context propagation is helping React fix it, or helping library maintainers work around this context issue.

Related:

• How to implement shouldComponentUpdate with this.context? facebook/react#2517
• RFC: Should update child context facebook/react#3973

[rpominov]

or helping library maintainers work around this context issue.

Well this is what I'm trying to do :)

I've made a PR with a possible fix #149 It requires a bit more work, but I wanted to ask first if this idea makes sense.

[gaearon]

Well this is what I'm trying to do :)

Oh, I meant libraries-relying-on-context-propagation, e.g. remix-run/react-router#470.

Longer term it's React's problem, but there are feasible workaround for specific libs today.
As you can see, for example, React Redux isn't affected because it doesn't read values from context.