datalake: dlq corrupted records #27327
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
requested review from
andrwng and
bharathv
and removed request for
andrwng
nvartolomei
force-pushed
the
nv/datalake-dlq-corrupted-records
branch
from
6c68128 to
0d6313c
Compare
andrwng
approved these changes
Aug 23, 2025
| @@ -609,4 +639,42 @@ record_multiplexer::handle_invalid_record( | |||
| co_return std::nullopt; | |||
| } | |||
| } | |||
|
|
|||
| ss::future<result<void, writer_error>> | |||
| record_multiplexer::handle_corrupted_record( | |||
There was a problem hiding this comment.
IMO this would be less surprising for callers / more accurate if it were called handle_corrupted_batch(), given we're treating the rest of the batch as corrupted, not just one record
bharathv
reviewed
Aug 27, 2025
Comment on lines
+147
to
+149
| _log.warn, | ||
| "Error reading record from batch: {} at index {}. Err: {}", | ||
| batch.header(), |
There was a problem hiding this comment.
nit: probably warrants an "error" log given the rarity of this situation.
| translation_probe::invalid_record_cause::corrupted_record, | ||
| o, | ||
| std::nullopt, | ||
| data_copy.share(0, data_copy.size_bytes()), |
There was a problem hiding this comment.
I'm wondering if we can only have the data payload for the first offset..
In the particular case where this crashed, the batch was > 100 MiB, seems wasteful to copy it over so many times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://redpandadata.atlassian.net/browse/INC-923
Backports Required
Release Notes
Bug Fixes