Skip to content

[25.1.x] datalake: Allow replacing dots in table names (MANUAL BACKPORT) #27321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2025
Merged

[25.1.x] datalake: Allow replacing dots in table names (MANUAL BACKPORT) #27321

merged 2 commits into from
Aug 28, 2025

Conversation

wdberkeley
Copy link
Contributor

Manual backport to resolve a trivial BUILD file conflict.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v25.2.x
  • v25.1.x
  • v24.3.x

Release Notes

Improvements

  • A new configuration option iceberg_topic_name_dot_replacement specifies a string that will replace dots in Iceberg topic names when those names are converted into Iceberg table names. This allows working around downstream systems which do not allow table names with dots in them. Be careful to avoid table name collisions by picking a proper replacement string, and do not change the replacement string if there exists an Iceberg topic with dots in the name.

@wdberkeley wdberkeley requested a review from andrwng August 20, 2025 23:46
@wdberkeley wdberkeley requested a review from a team as a code owner August 20, 2025 23:46
@wdberkeley
datalake: Allow replacing dots in table names
845da5d 
This defines a configuration property `iceberg_topic_name_dot_replacement`
that, when set, will replace .'s in table names when a Kafka topic name
is translated into the corresponding Iceberg table name (or DLQ table name).

The replacement is done using the current value of the setting, so to
preserve the link between topic and table, the setting should not be
changed once there is an Iceberg topic whose name contains dots. It'd be
nice to copy the cluster configuration into topic configuration when an
Iceberg topic is created or when Iceberg mode is set for a topic, so the
link is preserved even if the cluster configuration is changed, but
that's a far more invasive change. This workaround may suffice.

(cherry picked from commit 5cf2be1)
@wdberkeley wdberkeley force-pushed the backport-pr-27290-v25.1.x-770 branch from 63452c9 to 845da5d Compare August 21, 2025 01:12
@wdberkeley wdberkeley mentioned this pull request Aug 21, 2025
Closed
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#71169
test_class test_method test_arguments test_kind job_url test_status passed reason
kafka_server_rpfixture kafka_server_rpfixture unit https://buildkite.com/redpanda/redpanda/builds/71169#0198cd61-254a-4dda-972d-d382af8b5517 FLAKY 1/2

@lf-rep lf-rep merged commit 96c300f into redpanda-data:v25.1.x Aug 28, 2025
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrwng andrwng andrwng approved these changes

Assignees
No one assigned
Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wdberkeley @vbotbuildovich @andrwng @lf-rep