skip generating unused resources if issuerRef is set #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reytech-dev
requested review from
RafalKorepta,
alejandroEsc and
chrisseto
as code owners
| @@ -79,4 +79,5 @@ spec: | |||
| group: cert-manager.io | |||
| {{- end }} | |||
| {{- end }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
I think that will not work as {{- end }} is already present at 42 line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added one change avoiding the generation of not used/usable issuers (#1011) and certificates if a custom issuer is provided.
I added a dedicated values.yaml with a working test configuration.
But I'm missing the required custom cluster issuer: "custom-internal-issuer-ref"
Where can I add this cluster issuer to be available during the test run?
Regards