-
Notifications
You must be signed in to change notification settings - Fork 45
DOC-1629: Fix single sourcing and cross repo tags #1329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds environment-gated documentation updates in modules/manage/pages/schema-reg/schema-reg-authorization.adoc. For env-cloud, inserts RBAC references to cloud-specific docs (rbac_dp.adoc and rbac-dp with single-source tag). For non-cloud, retains the existing RBAC doc link. Introduces a non-cloud-only troubleshooting example for an “Invalid license: not present” error when creating ACLs, including command/output. No code or API changes; only AsciiDoc content conditioned by env-cloud. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(no out-of-scope changes detected) Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
modules/manage/pages/schema-reg/schema-reg-authorization.adoc (1)
357-378
: Standardize code block formatting and prompt style.For consistency with earlier examples in this page:
- Use
[,bash]
(or[source,bash]
) rather than[bash]
.- Drop the leading
$
prompt in commands (prior examples omit it).Suggested tweak:
-[bash] +[,bash] ---- -$ rpk security acl create --topic private --allow-principal mary --operation read --registry-subject private-key -v +rpk security acl create --topic private --allow-principal mary --operation read --registry-subject private-key -vContent and env-conditionalization look good otherwise.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/manage/pages/schema-reg/schema-reg-authorization.adoc
(3 hunks)
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Resolves (https://redpandadata.atlassian.net/browse/DOC-1629)
Review deadline:
Page previews
RBAC link in Cloud
RBAC link in SM
Checks