Skip to content

Reduce CLS #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 28, 2025
Merged

Reduce CLS #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81ba490
Reduce CLS
JakeSCahill Aug 27, 2025
b9796ca
Increase max-width
JakeSCahill Aug 27, 2025
f03af29
Update preloaded fonts
JakeSCahill Aug 27, 2025
77977eb
Remove unused bold
JakeSCahill Aug 27, 2025
0cfff59
Apply suggestions
JakeSCahill Aug 27, 2025
0a1d2e2
Merge branch 'main' into cls
JakeSCahill Aug 28, 2025
ae5879c
Update search-bump.css
JakeSCahill Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/css/footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ footer.footer {
color: var(--body-faint-font-color);
font-size: var(--secondary-font-size);
border-top: 1px solid var(--nav-border-color);
min-height: 60px;
}

footer nav.footer-nav {
Expand Down
10 changes: 10 additions & 0 deletions src/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
main > .content {
min-height: 0;
}

main.article {
min-height: calc(100vh - var(--body-top) - 60px);
display: flex;
flex-direction: column;
}

@media screen and (max-width: 1024px) {
aside.toc.sidebar {
display: none;
Expand Down
12 changes: 8 additions & 4 deletions src/css/search-bump.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,14 @@ article.search .ais-Heading > a {
padding: 12px;
}

/* Reserve space for Algolia preview panel to prevent CLS */
.aa-Preview.aa-Column.doc {
min-width: 350px;
max-width: 600px;
min-height: 400px;
margin-top: 0;
}

section.aa-Source[data-autocomplete-source-id=tagsPlugin] {
display: none;
}
Expand Down Expand Up @@ -515,10 +523,6 @@ kbd.algolia-command {
text-decoration: none;
}

.aa-Preview.aa-Column.doc {
margin-top: 0;
}

.aa-ItemContentTitle.result-type {
font-size: small;
padding: 0 6px;
Expand Down
12 changes: 8 additions & 4 deletions src/css/search.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,14 @@ article.search .ais-Breadcrumbs {
margin-left: 5px;
}

/* Reserve space for Algolia preview panel to prevent CLS */
.aa-Preview.aa-Column.doc {
min-width: 350px;
max-width: 600px;
min-height: 400px;
margin-top: 0;
}

article.search .ais-Pagination-list {
justify-content: space-evenly;
}
Expand Down Expand Up @@ -490,10 +498,6 @@ kbd.algolia-command {
text-decoration: none;
}

.aa-Preview.aa-Column.doc {
margin-top: 0;
}

.aa-ItemContentTitle.result-type {
font-size: small;
padding: 0 6px;
Expand Down
7 changes: 7 additions & 0 deletions src/partials/head.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
{{> head-prelude}}
{{> head-title}}
{{> head-info}}
<link rel="preload" href="{{{@root.uiRootPath}}}/font/Inter-Regular.ttf" as="font" type="font/ttf" crossorigin>
<link rel="preload" href="{{{@root.uiRootPath}}}/font/Inter-Medium.ttf" as="font" type="font/ttf" crossorigin>
<link rel="preload" href="{{{@root.uiRootPath}}}/font/Inter-SemiBold.ttf" as="font" type="font/ttf" crossorigin>
<link rel="preload" href="{{{@root.uiRootPath}}}/font/Inter-Light.ttf" as="font" type="font/ttf" crossorigin>
<link rel="preload" href="{{{@root.uiRootPath}}}/font/IBMPlexMono-Regular.ttf" as="font" type="font/ttf" crossorigin>
<link rel="preload" href="{{{@root.uiRootPath}}}/font/IBMPlexMono-Medium.ttf" as="font" type="font/ttf" crossorigin>
<link rel="preload" href="{{{@root.uiRootPath}}}/font/IBMPlexMono-SemiBold.ttf" as="font" type="font/ttf" crossorigin>
{{> head-styles}}
{{> head-meta}}
{{> head-icons}}
2 changes: 1 addition & 1 deletion src/partials/header-content.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
>
<div class="navbar-brand" id="brand">
{{#with site.homeUrl}}
<a class="navbar-item" href="{{{relativize this}}}" aria-label="Go to home page"><img src="{{{@root.uiRootPath}}}/img/redpanda-docs-logo-white.svg" width="auto" height="22px" alt="Redpanda logo"/></a>
<a class="navbar-item" href="{{{relativize this}}}" aria-label="Go to home page"><img src="{{{@root.uiRootPath}}}/img/redpanda-docs-logo-white.svg" width="150" height="22" style="aspect-ratio:150/22;" decoding="async" alt="Redpanda logo"/></a>
{{/with}}
<button class="navbar-burger" data-target="topbar-nav" aria-label="Header navigation menu">
<span></span>
Expand Down
Loading