Fix nav styles and remove module-level announcements #318
Conversation
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis change removes module-level announcement support from the codebase. The helper file responsible for extracting module-specific announcement data ( Sequence Diagram(s)sequenceDiagram
participant User
participant Page
participant AnnouncementBar
User->>Page: Load page
Page->>AnnouncementBar: Render with context (page, component-version, site)
alt Page-level announcement exists
AnnouncementBar->>User: Show page-level announcement
else Component-version-level announcement exists
AnnouncementBar->>User: Show component-version-level announcement
else Site-level announcement exists
AnnouncementBar->>User: Show site-level announcement
else
AnnouncementBar->>User: No announcement shown
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request includes changes to simplify and optimize the handling of navigation styles and announcement bar logic. The most important updates involve restructuring CSS for better responsiveness, removing unused helper functions, and cleaning up the announcement bar template.
CSS Improvements:
@mediaquery insrc/css/nav.cssto simplify responsive styles for.nav-containerand removed redundant definitions. ([[1]](https://github.com/redpanda-data/docs-ui/pull/318/files#diff-e2542659752e2de8d97af993968c93866ae25445a996b39dc55a22e71a352989L55-R60),[[2]](https://github.com/redpanda-data/docs-ui/pull/318/files#diff-e2542659752e2de8d97af993968c93866ae25445a996b39dc55a22e71a352989L113-L117))Announcement Bar Logic Simplification:
get-module-announcementhelper function fromsrc/helpers/get-module-announcement.js, as it is no longer used. ([src/helpers/get-module-announcement.jsL1-L30](https://github.com/redpanda-data/docs-ui/pull/318/files#diff-ebf7129a94a14e68a70a0241ab73ae35c950713c4ce0bcc14f3363627643b525L1-L30))src/partials/announcement-bar.hbstemplate by removing references toget-module-announcementand restructuring the logic for displaying announcements. ([src/partials/announcement-bar.hbsL1-L20](https://github.com/redpanda-data/docs-ui/pull/318/files#diff-9a8a6aea2db50056df305477e671e7fd52453840a40bb7506370550565cb7730L1-L20))