-
Notifications
You must be signed in to change notification settings - Fork 4
Update azure-private-link.adoc - use private DNS command #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for rp-cloud pending review.Visit the deploys page to approve it
|
📝 WalkthroughWalkthroughThe change updates documentation related to Azure Private Link by correcting the Azure CLI command used for creating a wildcard DNS record. Specifically, it replaces the use of the general Azure DNS command ( Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We can hold on merging, as this might cause issues for the PL workflow and I have not tested just yet. |
@micheleRP tested, please go ahead and merge. |
Description
We should be using the private dns subcommand instead of public.
Page previews
Checks