-
Notifications
You must be signed in to change notification settings - Fork 2
Schema-Registry: Update for v25.2.2 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ben Pope <[email protected]>
📝 WalkthroughWalkthroughThe schema-registry OpenAPI spec updates adjust responses and requests to use shared definitions. GET /schemas/ids/{id} and GET /schemas/ids/{id}/versions 200 responses now reference #/definitions/schema_def instead of inline objects. POST /subjects/{subject}/versions body parameter schema_def now references #/definitions/stored_schema instead of #/definitions/schema_def. Compatibility-related definitions were augmented: get_compatibility.compatibilityLevel and put_compatibility.compatibility gained description, example, and an enum with seven allowed values (BACKWARD, BACKWARD_TRANSITIVE, FORWARD, FORWARD_TRANSITIVE, FULL, FULL_TRANSITIVE, NONE). Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
schema-registry/schema-registry.json
(3 hunks)
🔇 Additional comments (3)
schema-registry/schema-registry.json (3)
462-463
: De-duplicating schema via $ref is good; adds references supportSwitching the 200 response of GET /schemas/ids/{id} to
#/definitions/schema_def
removes inline duplication and exposesreferences
, which aligns with richer responses in 25.2+. No functional concerns from me.
- Ensure any examples/snippets in the docs that previously showed only
schema
/schemaType
are updated to include optionalreferences
when present.
1554-1558
: Adding enum + metadata for get_compatibility is a solid improvementDefining explicit allowed values with description/example improves client generation and validation.
- Confirm the server treats these values case-insensitively (many users send lowercase); if so, consider documenting that behavior in the property description.
1565-1569
: Mirror enum + metadata for put_compatibility payloadConsistent constraints on the input model reduce invalid requests and improve UX in generated SDKs.
- If the backend normalizes values (e.g., to UPPERCASE), optionally call that out in the description to set expectations for echo responses.
No description provided.