Update timestamp conversion in client #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverting of str converting for timestamp to avoid error 'str object has no attribute timestamp' Resolves: #209
Collaborator
Author
|
Hi @filipecosta90 , @slice4e , could you please review? |
Contributor
@markovamaria please include a unit test that confirms we're OK with this change. |
filipecosta90
suggested changes
Feb 9, 2023
Contributor
filipecosta90
left a comment
filipecosta90
left a comment
There was a problem hiding this comment.
requires test. I can add it if required.
Collaborator
Author
added |
Collaborator
Author
|
REF 1: before fix: REF 2: after test added, before fix added: EXP: after test and fix added: |
Collaborator
Author
|
@filipecosta90 , please take a look. I've added test and related screenshots. |
slice4e
approved these changes
Feb 14, 2023
filipecosta90
approved these changes
Feb 14, 2023
Contributor
|
Nice. Thank you @markovamaria ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting of str converting for timestamp to avoid error 'str object has no attribute timestamp'
Resolves: #209