Skip to content

Fixes tests after memtier password args #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Fixes tests after memtier password args #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions redis_benchmarks_specification/__common__/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ def execute_init_commands(benchmark_config, r, dbconfig_keyname="dbconfig"):
cmds = None
res = 0
if dbconfig_keyname in benchmark_config:
# print(benchmark_config[dbconfig_keyname])
# print(type(benchmark_config[dbconfig_keyname]))
for k, v in benchmark_config[dbconfig_keyname].items():
if "init_commands" in k:
cmds = v
Expand All @@ -25,7 +23,6 @@ def execute_init_commands(benchmark_config, r, dbconfig_keyname="dbconfig"):
if cmds is not None:
for cmd in cmds:
is_array = False
print(type(cmd))
if type(cmd) == list:
is_array = True
if '"' in cmd:
Expand Down
2 changes: 1 addition & 1 deletion ...ests/test_data/test-suites/memtier_benchmark-1Mkeys-100B-expire-use-case-with-variant.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dbconfig:
configuration-parameters:
save: '""'
check:
keyspacelen: 1
keyspacelen: 0
preload_tool:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
Expand Down
2 changes: 1 addition & 1 deletion utils/tests/test_data/test-suites/memtier_benchmark-1Mkeys-100B-expire-use-case.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dbconfig:
configuration-parameters:
save: '""'
check:
keyspacelen: 1
keyspacelen: 0
preload_tool:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
Expand Down
22 changes: 11 additions & 11 deletions ...ests/test_data/test-suites/memtier_benchmark-2keys-stream-5-entries-xread-all-entries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@ dbconfig:
configuration-parameters:
save: '""'
check:
keyspacelen: 1
keyspacelen: 2
resources:
requests:
memory: 1g
init_commands:
xadd key-1 * field value
xadd key-1 * field value
xadd key-1 * field value
xadd key-1 * field value
xadd key-1 * field value
xadd key-2 * field value
xadd key-2 * field value
xadd key-2 * field value
xadd key-2 * field value
xadd key-2 * field value
- xadd key-1 * field value
- xadd key-1 * field value
- xadd key-1 * field value
- xadd key-1 * field value
- xadd key-1 * field value
- xadd key-2 * field value
- xadd key-2 * field value
- xadd key-2 * field value
- xadd key-2 * field value
- xadd key-2 * field value
tested-commands:
- xread
redis-topologies:
Expand Down
8 changes: 8 additions & 0 deletions utils/tests/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
)
Expand All @@ -40,6 +41,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
False,
Expand All @@ -60,6 +62,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
)
Expand All @@ -80,6 +83,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
tls_enabled,
Expand All @@ -98,6 +102,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
tls_enabled,
Expand All @@ -116,6 +121,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
tls_enabled,
Expand All @@ -136,6 +142,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
tls_enabled,
Expand All @@ -154,6 +161,7 @@ def test_prepare_memtier_benchmark_parameters():
client_tool,
12000,
"localhost",
None,
local_benchmark_output_filename,
oss_api_enabled,
tls_enabled,
Expand Down