Stop erasing ErrorReply stack
#3050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was very difficult to debug `ErrorReply` errors due to `error.stack` being erased. Given this restores standard JS Error behaviour, I have not added any tests.
|
@bobymicroby, @PavelPashov I dont see any reason not to merge this, but just to doublecheck with you? |
|
@nkaradzhov i don't know what was the rationale behind excluding the stack in first place tbh, but the patch looks ok to me |
nkaradzhov
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
error.stackbeing undefined makes debugging very difficult. I lost a few hours the other day trying to pinpoint the source of an error due to the emptystack.Given this restores standard JS Error behaviour, I have not included any tests.
Resolves #2482
Checklist
npm testpass with this change (including linting)?