Skip to content

Conversation

matsn0w
Copy link
Contributor

@matsn0w matsn0w commented Oct 1, 2021

Summary

  • Added a new command: php artisan make:graphql:schema <name>
  • Added test for new command

This new command can be used to quickly generate a new schema configuration class.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@matsn0w matsn0w marked this pull request as ready for review October 1, 2021 13:04
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But I think the command (and this all the class / test names, etc.) should be named schemaConfiguration (also fine with schemaConfig).

Otherwise it might be confusing because a "graphql schema" is definitely something else.

WDYT?

@matsn0w
Copy link
Contributor Author

matsn0w commented Oct 4, 2021

But I think the command (and this all the class / test names, etc.) should be named schemaConfiguration (also fine with schemaConfig).

Otherwise it might be confusing because a "graphql schema" is definitely something else.

WDYT?

That makes sense. I'd go with the shorter schemaConfig for the sake of not having to type that out entirely ;)

@matsn0w matsn0w requested a review from mfn October 4, 2021 06:55
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


However I've to merge your PR via #840 because you had PHP 8 specific changes (the project is PHP 7.2+) and some other phpstan issue I solved there.

Rest assured your authorship is retained!

@mfn mfn merged commit 230ae17 into rebing:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants