-
-
Notifications
You must be signed in to change notification settings - Fork 270
Add command for schema class generation #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
But I think the command (and this all the class / test names, etc.) should be named schemaConfiguration
(also fine with schemaConfig
).
Otherwise it might be confusing because a "graphql schema" is definitely something else.
WDYT?
That makes sense. I'd go with the shorter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
However I've to merge your PR via #840 because you had PHP 8 specific changes (the project is PHP 7.2+) and some other phpstan issue I solved there.
Rest assured your authorship is retained!
Summary
php artisan make:graphql:schema <name>
This new command can be used to quickly generate a new schema configuration class.
Type of change:
Checklist:
composer fix-style