tests: refactor for upcoming middleware changes #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the benefit in case of error/exceptions during runtime, we don't get back the HTML error page but a JSON serializable representation aka more readable for devs. I'm aware that technically the $response is a `TestResponse`, but for all intents and purposes, in this context we just use it as JsonReponse.
This will allow greater compatibility with the upcoming refactorings
This will allow greater compatibility with the upcoming refactorings
Replaced either with httpGraphql or just directly with the Facade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a preparation for #762
Because the approach used by the current
querymethod won't be compatible with the upcoming changes, some under-the-hood refactoring will applied.Type of change:
Checklist:
composer fix-style