Improve error handling when sending data to DNS server fails (macOS) #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build currently fails due to another flaky test on macOS, seems to be 3/4 chance of it failing. Looks like it could be related to reactphp/stream#150, but after patching this I still get a 1/3 chance of it failing (https://github.com/clue-labs/dns/runs/1873816008?check_suite_focus=true). I'll look into this again no later than tomorrow |
jsor
approved these changes
Feb 11, 2021
WyriHaximus
approved these changes
Feb 11, 2021
This was referenced Feb 25, 2021
This was referenced Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves error handling when sending data to the DNS server fails. This is a quite rare error condition but something that can be reproduced when using faulty DNS server entries on macOS (e.g. exposedev/expose#25 (comment)).
Together with @SimonFrings, I'm currently in the process of migrating from Travis to GitHub actions and improving our test matrix. We've noticed a similar error in the (upcoming) PR for the socket component on macOS only, so I figured it's a good idea to address this upstream (here) instead.
Builds on top of #170 and reactphp/stream#157