-
-
Notifications
You must be signed in to change notification settings - Fork 1
Php81 compat #16
Php81 compat #16
Conversation
This is a known issue, there is one major blocker that blocks the remaining few dependencies from fully being 8 and 8.1 compatible and requireable. So that should be resolveable with a version bump of that tests utilities package in the future. Alternatively we can skip some checks for now.
👍
Switch to NTS images, this package doesn't need ZTS |
Moved CI to NTS, remove the alpine version constraint as well. |
Hah awesome you picked up on that 🎉 |
f8e7982
to
ef17840
Compare
ef17840
to
9ed7bea
Compare
Looking great so far, made two suggestions that will make sure we can see all jobs run and see all potential failures |
3e3e0cb
to
f90df88
Compare
I tried to update / fix dependencies where possible but I think I am at a dead end. Most dev dependencies are rather old and would need to be updated for PHP8. For that an update of |
f90df88
to
c5bf13a
Compare
Figured the BC issue might be the reason you had the platform set to 7.4 in the composer file. Removed all dev dependencies from the composer file and updated the testing package. Now only infection is failing for 8.1 due to the lack of code coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you so much for this :D! I Will update the test coverage over the weekend and release a new version.
|
Had a few issues getting this to run: