Skip to content
This repository was archived by the owner on Oct 14, 2022. It is now read-only.

Conversation

fritz-gerneth
Copy link
Contributor

Had a few issues getting this to run:

  1. composer.lock - could not install locked dependencies, not all used dependencies were present in composer.json. Rebuilt composer.json with all dependencies
  2. PHPCS - Applied rules per phpcs
  3. workflow - there are no php 8.(0/1)-zts-alpine images, cannot add to workflow

@WyriHaximus
Copy link
Contributor

  1. composer.lock - could not install locked dependencies, not all used dependencies were present in composer.json. Rebuilt composer.json with all dependencies

This is a known issue, there is one major blocker that blocks the remaining few dependencies from fully being 8 and 8.1 compatible and requireable. So that should be resolveable with a version bump of that tests utilities package in the future. Alternatively we can skip some checks for now.

  1. PHPCS - Applied rules per phpcs

👍

  1. workflow - there are no php 8.(0/1)-zts-alpine images, cannot add to workflow

Switch to NTS images, this package doesn't need ZTS

@fritz-gerneth
Copy link
Contributor Author

Moved CI to NTS, remove the alpine version constraint as well.

@WyriHaximus
Copy link
Contributor

Moved CI to NTS, remove the alpine version constraint as well.

Hah awesome you picked up on that 🎉

@fritz-gerneth fritz-gerneth marked this pull request as ready for review October 22, 2021 11:43
@WyriHaximus
Copy link
Contributor

Looking great so far, made two suggestions that will make sure we can see all jobs run and see all potential failures

@fritz-gerneth fritz-gerneth force-pushed the php81-compat branch 4 times, most recently from 3e3e0cb to f90df88 Compare October 27, 2021 09:57
@fritz-gerneth
Copy link
Contributor Author

I tried to update / fix dependencies where possible but I think I am at a dead end. Most dev dependencies are rather old and would need to be updated for PHP8. For that an update of wyrihaximus/test-utilities is required. Unfortunately any version >= 2.5 requires roave/backward-compatibility-check which is not php8 compatible.

@fritz-gerneth
Copy link
Contributor Author

Figured the BC issue might be the reason you had the platform set to 7.4 in the composer file. Removed all dev dependencies from the composer file and updated the testing package. Now only infection is failing for 8.1 due to the lack of code coverage.

Copy link
Contributor

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you so much for this :D! I Will update the test coverage over the weekend and release a new version.

@WyriHaximus WyriHaximus merged commit 7c61180 into reactphp-inspector:master Oct 29, 2021
@WyriHaximus WyriHaximus added this to the 1.1.0 milestone Oct 29, 2021
@WyriHaximus
Copy link
Contributor

v1.1.0 has just been released with these changes in it 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants