Skip to content

Conversation

@Rumbustious
Copy link
Contributor

@Rumbustious Rumbustious commented Sep 26, 2023

(Reacting to Input) page translation is now done! Sorry for being late, I was busy lately.
Here are some notes to help reviewers:

  • the word "حالة" in all translation refer to the "state" in React but the reader may misunderstand it, so should I write (state) whenever I refer to the state or not?
  • Names of Cities (Lima & Istanbul) in "City quiz" code example is not translated. I haven't also translated it in the same example in "Managing state" page.
  • Name "Jane Jacob" isn't not translated in the challenge section
  • I've notice in the translation that they used the pronouns (they, them) to make the speech general, so I've translated to refer to masculine. (See lines 29 & 33)
  • The "alt" attributes haven't been translated to Arabic.
  • The links to wiki is not changed, I don't know if it should be directed to the Arabic wiki.
  • "mock" is translated to "تحربة" and "mockup" & "mock up" are translated to "نماذج تجريبية".
  • "iterate" is translated to "التكرار"
  • "storybooks, living styleguides, and sandbox) are kept untranslated, I didn't know If I should translate "sandbox" to "ساحة اللعب".
  • "Boolean" is translated to "قيمة منطقية"
  • "Explicit" translated to "بيّنة" not sure if it should be translated to "واضحة" or something else.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Co-authored-by: Ahmed Abdelbaset <[email protected]>
Rumbustious and others added 3 commits October 10, 2023 06:46
@AhmedBaset AhmedBaset merged commit 226f9cb into reactjs:main Oct 10, 2023
@AhmedBaset
Copy link
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants