Skip to content

Conversation

ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Dec 3, 2021

What kind of change does this PR introduce?

fix

What is the current behaviour?

"Xamarin.AndroidX.Preference" Version="1.1.1.12", "Xamarin.AndroidX.Lifecycle.LiveData" Version="2.4.0.1" and "Xamarin.Google.Android.Material" Version="1.4.0.5" requires a newer Xamarin.AndroidX.Core version than Xamarin.Forms currently supports

What is the new behaviour?

rollback due to a breaking change in Xamarin packages

What might this PR break?

none expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@ChrisPulman ChrisPulman enabled auto-merge (squash) December 3, 2021 20:03
Copy link
Contributor

@worldbeater worldbeater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also stumbled upon this at reactiveui/ReactiveUI.Validation#397

Skip tests with null schedulers when built in the cloud
@ChrisPulman ChrisPulman merged commit 3bb5046 into main Dec 4, 2021
@ChrisPulman ChrisPulman deleted the fix_CP_AndriodX_rollbackPackages branch December 4, 2021 00:37
worldbeater added a commit to reactiveui/ReactiveUI.Validation that referenced this pull request Dec 8, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants