Skip to content

Conversation

HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Oct 28, 2021

What kind of change does this PR introduce?

Updated ReactiveUI.WinUI to use Microsoft.WindowsAppSDK.

What is the current behavior?

Using ProjectReunion which doesn't work in real projects.

Copy link
Contributor

@worldbeater worldbeater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ProjectReunion is now WindowsAppSDK 💯
Are we ready for a preview* dependency version though?

@glennawatson
Copy link
Contributor

Not a fan of any preview dependencies but given it's isolated to its own project not too bad.

@glennawatson glennawatson merged commit aa50420 into reactiveui:main Oct 28, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants