Skip to content

Conversation

@orta
Copy link
Member

@orta orta commented Aug 1, 2019

Re: facebook/react-native#25882 and DefinitelyTyped/DefinitelyTyped#37303

Will allow the default app to compile out of the box.

Copy link
Member

@emin93 emin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for the delayed review.

@emin93 emin93 merged commit eae5bed into master Aug 12, 2019
@emin93
Copy link
Member

emin93 commented Aug 12, 2019

@orta
Copy link
Member Author

orta commented Aug 12, 2019

No worries, thanks!

@emin93 emin93 deleted the orta-patch-1 branch September 11, 2019 09:12
@radko93
Copy link
Collaborator

radko93 commented Sep 26, 2019

@orta does this actually work? Because when you run this on iOS HermesInternal is {} and that is not true? It's just checking the type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants