Update App.tsx custom global variable declaration #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our custom global variable would be nicer declared as a `const`. `var` doesn't seem to present any advantages here. Functionality-wise the block scope remains the same as the global scope. Semantic-wise it's clear it is global as @emin93 already moved it below imports. Also ib4 wave of ESLint `no-var` adopters (e.g. https://github.com/gabts/eslint-config-react-native-typescript). Further, see: https://eslint.org/docs/rules/no-var#when-not-to-use-it
radko93
approved these changes
Apr 13, 2020
Collaborator
radko93
left a comment
radko93
left a comment
There was a problem hiding this comment.
This makes sense, of course, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our custom global variable would be nicer declared as a
const.vardoesn't seem to present any advantages here.Functionality-wise the block scope remains the same as the global scope.
Semantic-wise it's clear it is global as @emin93 already moved it below imports.
Also ib4 wave of ESLint
no-varadopters (e.g. gabts/eslint-config-react-native-typescript)Further: https://eslint.org/docs/rules/no-var#when-not-to-use-it
Test Plan
What's required for testing (prerequisites)?
'no-var': 'off'to .eslintrc rulesWhat are the steps to reproduce (after prerequisites)?
yarn lintCompatibility