Return empty list instead of null from getViewManagerNames
#284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krozniata friendly bump plz review 🙏 |
|
@tomekzaw works fine for me 🙏 @Naturalclar can we get this merged? 👀 |
Naturalclar
approved these changes
Jun 14, 2025
|
Thank you! Will merge and publish soon |
|
Hi @Naturalclar. Thank you for your continued work on this library. Could you release a new version with fix for compatibility with RN 0.80.0 please? This fix is quite important for the community as many developers are upgrading to RN 0.80.0. facebook/react-native#52014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an initialization error on Android while using
@react-native-clipboard/clipboardin a React Native 0.80.0-rc.0 app. See https://github.com/facebook/react-native/blob/77c1eb615400c07fd2a7d7f4a47dd87cef1c8743/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactInstance.kt#L544-L545. Note thataddAllmethod requires the argument to be non-null.Test Plan