Make page_size
a runtime value
#13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a WASM test harness for the Roc programming language Playground using Bytebox -- and our CI uncovered a bug in zig-stable-array,
Here is a gist with the original failure in CI from a
ubuntu-24.04-arm
machineThis change refactors
StableArrayAligned
to storepage_size
as an instance field rather than using a global, compile-time constant.The
page_size
is now captured fromheap.pageSize()
in theinit
function and stored on the struct instance. All internal memory calculations have been updated to use this instance-specificpage_size
.