Skip to content

Conversation

TUSF
Copy link
Contributor

@TUSF TUSF commented Apr 3, 2025

Aside from the package manager changes, there's also how page_size is no longer a comptime-known constant. I considered using std.heap.pageSize(), but given the page size is being used in type information, I went with the comptime-known std.heap.page_size_min.

Not sure if page_size_max would be better?

@rdunnington
Copy link
Owner

Hey thanks for your interest! I will take a closer look this weekend, but offhand the right thing to do feels like to use the runtime page size where appropriate, and figure out a way to cast pointers without having the alignment be in type info.

@rdunnington rdunnington mentioned this pull request Apr 7, 2025
@rdunnington
Copy link
Owner

Wound up keeping the min page size in the alignment info as suggested, and changed over to use the real page size in actual size allocations. Thanks for the PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants