[ci] point refresh compile commands to :ray_pkg_zip

[aslonnie]

deprecating :ray_pkg rule

[aslonnie]

@dayshah could you check if this change works? I am not really sure how to use or test this refresh_compile_commands thing.

[gemini-code-assist]

Code Review

This pull request updates the refresh_compile_commands target in BUILD.bazel to point to //:ray_pkg_zip instead of //:ray_pkg. This change is part of the effort to deprecate the :ray_pkg rule. The new target, :ray_pkg_zip, is a more direct dependency for the C++ compilation actions that refresh_compile_commands needs to extract, making the build configuration cleaner and more accurate. The change is correct and improves the build system's maintainability. I have no further comments.

[dayshah]

@dayshah could you check if this change works? I am not really sure how to use or test this refresh_compile_commands thing.

do we need to change this? are we killing the ray_pkg target entirely?

[aslonnie]

are we killing the ray_pkg target entirely?

yes.

[dayshah]

🚢

[aslonnie]

for context, the issue with :ray_pkg is that it does not actually output the bits to bazel (not declaring them as output), it just runs in the local source dir, and generates the required bits as a side effect of the build process.

if I understand how refresh_compile_commands works, using ray_pkg_zip should have the same effect (which is generating the compile commands for the c/c++ parts)

[dayshah]

for context, the issue with :ray_pkg is that it does not actually output the bits to bazel (not declaring them as output), it just runs in the local source dir, and generates the required bits as a side effect of the build process.

if I understand how refresh_compile_commands works, using ray_pkg_zip should have the same effect (which is generating the compile commands for the c/c++ parts)

ya will have the same effect