Add extra checks to check_board_header.py #1775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t can be more easily extended
Note that UART_CTS, UART_RTS & SPI_CSN are classed as optional
|
arguably you don't need to have both UART TX and UART RX |
Ahh, I was wondering about that but wasn't sure. Is a similar thing true for SPI where you have to have SPI_SCK, but you might have only a SPI_TX or only a SPI_RX ? |
… present) and "one_of" (at least one of these pins must be present)
Fixed with the latest commit 🙂 |
kilograham
approved these changes
Jul 25, 2024
Kushal-hub1
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is checking that each "interface" has pins for all of its required "functions".
E.g. if you define
PICO_DEFAULT_I2Cthen you also have to define bothPICO_DEFAULT_I2C_SDA_PINandPICO_DEFAULT_I2C_SCL_PIN, and if you definePICO_DEFAULT_UARTthen you also have to define at least one ofPICO_DEFAULT_UART_TX_PINorPICO_DEFAULT_UART_RX_PIN.