Skip to content

Conversation

rancher-ui-project-bot[bot]
Copy link

@rancher-ui-project-bot rancher-ui-project-bot bot commented Aug 26, 2025

This is an automated request to port PR #15205 by @nwmac

Original PR body:

Summary

Fixes #15228

Occurred changes and/or fixed issues

This PR improves the handling of custom home page links.

Areas or cases that should be tested

Check that custom links can still be added via settings and show on the home page links section.

Areas which could experience regressions

This is a scoped change and is not expected to impact other areas.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.12.2 milestone Aug 26, 2025
@rancher-ui-project-bot rancher-ui-project-bot bot modified the milestones: v2.12.2, v2.13.0 Aug 26, 2025
@nwmac nwmac requested a review from rak-phillip August 26, 2025 08:37
@rancher-ui-project-bot rancher-ui-project-bot bot modified the milestones: v2.13.0, v2.12.2 Aug 26, 2025
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think we need a rebase now that #15202 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants