Fix --skip-foo switches when there's a trailing non-switch
#679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspected that more people would've run into this and I found an open issue: #580. I'll edit the PR description so it gets autoclosed if/when merged. |
|
Thanks for fixing this ... I completely forgot about it, got used to always specify the boolean flags with |
|
No problem! |
This was referenced Sep 26, 2019
Merged
|
@doudou Funny enough, my fix broke your workaround and I got beaten by it myself. I added a follow up PR to restore support for that syntax so that you and I don't have to change all of our scripts, tests or whatever to use the previous syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running the command
bundle exec rails new --dev --skip-webpack-install my_projectinside my Rails clone, but Rails generators kept runningrails webpacker:install.Turns out
thorwas consideringmy_projectas the value for the--skip-webpack-installswitch. However, I think the command line I specified is correct and non-ambiguous and that--no-and--skip-flags are not supposed to have a value.This PR fixes this edge case.
It adds two tests, the first one is already passing against master, the second one is fixed by this PR. So, I think it also makes the behaviour more consistent.
Fixes #580.