Allow Option to be repeatable #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Its been a week, and I understand people are busy, but I'd appreciate an estimate on when someone will be able to review this pr. |
|
Aha! This is great! |
This was referenced Sep 16, 2019
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pickups where #468 (comment) left off. It adds a new option to
Option::repeatable. This allows a flag to be repeated and the results collected into an array. The one exceptions is for type Hash, where I merge the hashes into a a single hash. If we'd prefer an array of hashes, I'll be happy to change the behavior.I'm happy to write up some docs, though not sure where to do that.
I've read the contributing guidelines 🌈.
cc: @rafaelfranca