Lazily load fileutils and tmpdir #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes some fileutils redefintion warnings that happen when you boot a
railsapplication that usesspringon a system with a defaultfileutilsversion, and a higher version of thefileutilsgem available as well. This can happen, for example, on ruby 2.6.Repro instructions are here: ruby/fileutils#22 (comment).
The short explanation of why this happens is that
springloads without usingbundler, so the fileutilsrequireuses rubygems version ofKernel.requirewhich automatically activates the latest version of the corresponding gem if arequireargument matches a default gem (likefileutils). Thenrailsitself also requiresfileutils, but at that pointbundleris already loaded, andbundlerdoes not changeKernel.requireat all, hence the default version offileutilsis chosen this time.By lazily loading
fileutils, we make sure thatbundleris always loaded beforefileutils, and thus the version that ends up being required is consistent.The explanation of why also lazily loading
tmpdiris becausetmpdiralso loadsfileutils.