Skip to content

migrate to plugin system #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2025
Merged

migrate to plugin system #28

merged 2 commits into from
Feb 20, 2025

Conversation

seuros
Copy link
Member

@seuros seuros commented Feb 15, 2025

https://docs.rubocop.org/rubocop/plugin_migration_guide.html

Both dependencies already moved to plugin system.

@thomaswitt
Copy link

I would appreciate a merge, the errors are very annoying.

@krzysztofkeczkowski
Copy link

Yeah. Yellow warnings are a little too much:

rubocop-performance extension supports plugin, specify plugins: rubocop-performance instead of require: rubocop-performance in /Users/krzysztofkeczkowski/.asdf/installs/ruby/3.3.4/lib/ruby/gems/3.3.0/gems/rubocop-rails-omakase-1.0.0/rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

rubocop-rails extension supports plugin, specify plugins: rubocop-rails instead of require: rubocop-rails in /Users/krzysztofkeczkowski/.asdf/installs/ruby/3.3.4/lib/ruby/gems/3.3.0/gems/rubocop-rails-omakase-1.0.0/rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

rubocop-minitest extension supports plugin, specify plugins: rubocop-minitest instead of require: rubocop-minitest in /Users/krzysztofkeczkowski/.asdf/installs/ruby/3.3.4/lib/ruby/gems/3.3.0/gems/rubocop-rails-omakase-1.0.0/rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

jeremy
jeremy approved these changes Feb 20, 2025
View reviewed changes
@jeremy jeremy merged commit 08dfee1 into rails:main Feb 20, 2025
@jesperronn
Copy link

who can trigger a release of the gem with these changes?

@jesperronn jesperronn mentioned this pull request Feb 20, 2025
Closed
@Earlopain Earlopain mentioned this pull request Feb 21, 2025
Merged
@koic koic mentioned this pull request Mar 3, 2025
Merged
4 tasks
kamipo pushed a commit to rails/rails that referenced this pull request Mar 3, 2025
@koic
Use RuboCop plugin
0720124 
## Summary

Follow-up rubocop/rubocop#13792

Plugin system was introduced in RuboCop 1.72. This PR updates RuboCop extension gems to use plugins:
https://docs.rubocop.org/rubocop/plugin_migration_guide.html

For `rubocop-packaging`, although plugin support has already been merged, it has not been released yet.
Therefore, it remains using the old `require`:
utkarsh2102/rubocop-packaging#54

## Additional Information

In `rubocop-rails-omakase`, the RuboCop plugin is now used and has been released in version 1.1.0:

- rails/rubocop-rails-omakase#28
- https://github.com/rails/rubocop-rails-omakase/releases/tag/v1.1.0
@larouxn larouxn mentioned this pull request May 19, 2025
Merged
@larouxn
Copy link
Contributor

larouxn commented May 19, 2025

👋 I have a follow up PR open to pick up a plugin system bug fix that was released in RuboCop v1.74.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy jeremy jeremy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seuros @thomaswitt @krzysztofkeczkowski @jesperronn @larouxn @jeremy