Skip to content

Conversation

@thorsteneckel
Copy link
Contributor

As stated in #130 this improves the performance of delete_session in case there is no existing session.

The delete_session method uses the get_session_model method which creates a new instance if no existing is found only to destroy it afterwards. Using @@session_class.find_by_session_id(id) instead (which is get_session_model doing too) works fine in our env and avoids the overhead.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sikachu (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants