Improved performance of delete_session in case there is none #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #130 this improves the performance of
delete_sessionin case there is no existing session.The
delete_sessionmethod uses theget_session_modelmethod which creates a new instance if no existing is found only to destroy it afterwards. Using@@session_class.find_by_session_id(id)instead (which isget_session_modeldoing too) works fine in our env and avoids the overhead.