increase possible metric name permutations #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This project was written to be able to generate metric names that were randomized in only one token of the name, which limits its usefulness in testing metric tokens at scale because all the tokens but one are the same. In other words, even with a long name pattern like org.example.a.1.b.2.c.3.d.4.e.5.f.6.%d and your randomization factor set to 1000, you still only get 1001 tokens because all tokens leading up to the final one never change. By interspersing more randomness in that name, the number of tokens rises dramatically. This adds the ability to do that through a new property, keeping the original behavior because tests rely on it extensively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project was written to be able to generate metric names that were randomized in only one token of the name, which limits its usefulness in testing metric tokens at scale because all the tokens but one are the same.
In other words, even with a long name pattern like org.example.a.1.b.2.c.3.d.4.e.5.f.6.%d and your randomization factor set to 1000, you still only get 1001 tokens because all tokens leading up to the final one never change. By interspersing more randomness in that name, the number of tokens rises dramatically.
This adds the ability to do that through a new property, keeping the original behavior because tests rely on it extensively.