query for 1 minute of annotations instead of 1 day #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I ramped the load test up on staging, it started making query nodes run out of memory. I traced it back to the annotations queries here, which appears to run a query similar to the others, but it fails to account for the fact that "annotations" are just little json blobs to keep track of discrete events. They don't form any time series and aren't rolled up. It's fine to query for a day's metrics because you'll get downsampled data, but annotations just accumulate, and if you run the load test for the whole day, by the end of it, there are far too many annotations to fit into memory when generating the payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ramped the load test up on staging, it started making query nodes run out of memory. I traced it back to the annotations queries here, which appears to run a query similar to the others, but it fails to account for the fact that "annotations" are just little json blobs to keep track of discrete events. They don't form any time series and aren't rolled up. It's fine to query for a day's metrics because you'll get downsampled data, but annotations just accumulate, and if you run the load test for the whole day, by the end of it, there are far too many annotations to fit into memory when generating the payload.