Use github packages for our container image #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirahImage
requested changes
Aug 29, 2025
[Why] To automatically use the latest version, and not having to update CI everytime there are new Go minors.
MirahImage
approved these changes
Aug 29, 2025
Add dependabot groups.
Bumps the all group with 3 updates: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `github.com/onsi/ginkgo/v2` from 2.25.1 to 2.25.2 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.25.1...v2.25.2) Updates `k8s.io/apimachinery` from 0.33.4 to 0.34.0 - [Commits](kubernetes/apimachinery@v0.33.4...v0.34.0) Updates `sigs.k8s.io/controller-runtime` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-version: 2.25.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: k8s.io/apimachinery dependency-version: 0.34.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.22.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <[email protected]>
…e6a677 build(deps): bump the all group with 3 updates
This prevents warnings of version mismatch between installed ginkgo CLI and ginkgo version used in tests.
[Why] After PR rabbitmq/rabbitmq-server#14359 RabbitMQ verifies that an authN/authZ plugin is enabled, if set in the configuration. We relied on the old behaviour that simply accepted the configuration. We have to change our test because the configuration is not valid anymore since 4.2.0
|
Test should pass after merging #1938 and rebasing |
Bump tools and deps. Fix broken system test (was relying on a bug in RabbitMQ that has been fixed).
[Why] To automatically use the latest version, and not having to update CI everytime there are new Go minors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
Additional Context
N/A
Local Testing
You can verify the new make target with:
And observe a manifest file specific for ghcr, and with an image reference to
ghcr.ioJob showing a successful push to ghcr: https://github.com/rabbitmq/cluster-operator/actions/runs/17293728273/job/49087638691