Add bits of documentation, small refactors and some formatting (fill-paragraphs) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, quick question before I do anything else. Are you ok with me moving the code into a subfolder ( and, are you ok with me splitting up If so, I'll create 1 or 2 PR just for these changes. And only after I'll try to actually improve the code. |
Yes.
If the split is good, sure. |
fstamour
force-pushed
the
feat/cleanup
branch
2 times, most recently
from
ec5aaad to
8126023
Compare
fstamour
commented
Jul 16, 2024
|
🐖 |
fstamour
changed the title
|
@stylewarning There, this MR should be good to merge I think |
- add docstring to the package "cluck/examples/cas" - ran emacs' "fill-paragraph" on some (all?) docstrings and comments - clean up the functions "e-graph-print" and "e-graph-plot-dot" - extract function "warn-if-dirty" - remove argument "e-node-car-to-printable" - replace a loop+format+print-to-string with a one format - use "second" instead of "cadr" - tweak format ~d -> ~D and nodes -> node~:P - when not => unless - reduced nesting and indentation with small refactors in: - defmethod initialize-instance :after ((pattern graph-pattern) &key) - defun check-graph-binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apart from the obvious move into src/ and split, I removed the function "prin1-e-node-to-string" and I might have broken something doing that. I didn't test yet.
I also extracted a function
warn-if-dirty