Added a handler to dynamically change the log level. #4662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
dynamic-log-level
branch
from
be98f4f to
7af5045
Compare
Usage example: just visit. http://localhost:7280/api/v1/log_level?filter=debug,hyper=debug,tantivy=info,quickwit_serve=debug
fulmicoton
force-pushed
the
dynamic-log-level
branch
2 times, most recently
from
e44561a to
62bf18b
Compare
trinity-1686a
approved these changes
Mar 1, 2024
| @@ -39,7 +40,7 @@ pub fn setup_logging_and_tracing( | |||
| level: Level, | |||
| ansi_colors: bool, | |||
| build_info: &BuildInfo, | |||
| ) -> anyhow::Result<()> { | |||
| ) -> anyhow::Result<EnvFilterReloadFn> { | |||
| #[cfg(feature = "tokio-console")] | |||
| { | |||
| if std::env::var_os(QW_ENABLE_TOKIO_CONSOLE_ENV_KEY).is_some() { | |||
There was a problem hiding this comment.
there is a type error when that feature is enabled Result<()> vs Result<EnvFilterReloadFn>
Comment on lines
36
to
38
| warp::path("log_level") | ||
| .and(warp::path::end()) | ||
| .and(with_arg(env_filter_reload_fn)) |
There was a problem hiding this comment.
there is no http method selector. this also works with POST, PUT, DELETE, INVALID...
(nonblocking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage example: just visit.
http://localhost:7280/api/v1/log_level?filter=debug,hyper=debug,tantivy=info,quickwit_serve=debug