Skip to content

Index template API #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2024
Merged

Index template API #4456

merged 1 commit into from
Jan 30, 2024

Conversation

guilload
Copy link
Member

@guilload guilload commented Jan 24, 2024 •
edited
Loading

In progress.

Todo

  • REST API
  • Postgres impl
  • Write more unit tests
  • Index template serialization format regression tests
  • REST API tests
  • Test rollback on error for file-backed impl
  • Rename table to index_templates
  • Misc. clean ups
  • Add test for create index
  • Write e2e integration test

@guilload guilload force-pushed the guilload/template-api branch 13 times, most recently from d536860 to c49cbd8 Compare January 28, 2024 03:53
@guilload guilload requested a review from fmassot January 28, 2024 03:53
@guilload guilload marked this pull request as ready for review January 28, 2024 03:55
@guilload guilload force-pushed the guilload/template-api branch 2 times, most recently from 5216330 to 0b388b4 Compare January 28, 2024 04:43
@guilload guilload changed the title Index template Index template API Jan 28, 2024
@guilload guilload force-pushed the guilload/template-api branch 7 times, most recently from 6e5fef2 to c8c4e65 Compare January 28, 2024 18:20
fmassot
fmassot reviewed Jan 29, 2024
View reviewed changes
fmassot
fmassot reviewed Jan 29, 2024
View reviewed changes
fmassot
fmassot reviewed Jan 29, 2024
View reviewed changes
@guilload guilload force-pushed the guilload/template-api branch from c8c4e65 to b9fbbf4 Compare January 29, 2024 19:20
fmassot
fmassot approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just a bit worried with migrations stuff.

I will test the templates stuff tomorrow.

@guilload guilload force-pushed the guilload/template-api branch 3 times, most recently from 31e1d97 to 83dbc05 Compare January 30, 2024 19:29
@guilload guilload force-pushed the guilload/template-api branch from 83dbc05 to b0c92e4 Compare January 30, 2024 19:37
@guilload guilload merged commit bd75a36 into main Jan 30, 2024
@guilload guilload deleted the guilload/template-api branch January 30, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilload @fmassot