Fix test flake in pauli_string_measurement_with_readout_mitigation_test #7459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_error_on_missing_calibration
Problem: Random Pauli strings generated in the test may not contain all possible qubits
causing KeyError for the assumed `empty_calibration_result_dict`.
Solution: Make dictionary for the qubits occuring in Pauli strings.
Fixes spurious test failure
pytest --randomly-seed=532866775 \
cirq-core/cirq/contrib/paulistring/pauli_string_measurement_with_readout_mitigation_test.py \
-k test_process_pauli_measurement_results_raises_error_on_missing_calibration
Rewrite so that `test_circuits` contains 3 circuits instead of 1.
|
@ddddddanni - can you PTAL? This should prevent flake as in https://github.com/quantumlib/Cirq/actions/runs/16012035778/job/45171597863?pr=7457. [NB - can be reviewed commit-by-commit] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7459 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1092 1092
Lines 96546 96542 -4
=======================================
+ Hits 95272 95273 +1
+ Misses 1274 1269 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for fixing it!! Looks good to me. |
NoureldinYosri
approved these changes
Jul 2, 2025
ddddddanni
added a commit
to ddddddanni/Cirq
that referenced
this pull request
Jul 15, 2025
…st (quantumlib#7459) Avoid possible KeyError in `test_process_pauli_measurement_results_raises_error_on_missing_calibration` Problem: Random Pauli strings generated in the test may not contain all qubits as is assumed in the `empty_calibration_result_dict` key. Solution: Make dictionary with the qubits present in Pauli strings. Fixes spurious test failure ``` pytest --randomly-seed=532866775 \ cirq-core/cirq/contrib/paulistring/pauli_string_measurement_with_readout_mitigation_test.py \ -k test_process_pauli_measurement_results_raises_error_on_missing_calibration ``` Also fix - unnecessarily repeated list construction - unintentional dropping of circuits in a loop - Nit - sync docstring with function arguments
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid possible KeyError in
test_process_pauli_measurement_results_raises_error_on_missing_calibrationProblem: Random Pauli strings generated in the test may not contain all qubits
as is assumed in the
empty_calibration_result_dictkey.Solution: Make dictionary with the qubits present in Pauli strings.
Fixes spurious test failure
Also fix