Avoid Moment typechecks when (un)freezing circuits #7150
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
When freezing or unfreezing circuits, we have a list or tuple of
Momentobjects so we can call the_from_momentsclassmethod on the relevant target type which avoids theisinstancetypechecks that are needed when callingfrom_momentsas we do currently.See below for a microbenchmark of this change. On main, freezing an example circuit with 10_001 moments takes something like 550us, while on this branch the same freeze operation takes about 40us (note that we have to copy the circuit before freezing because we cache the result of
freezeif a circuit has not been mutated).With main:
With this branch: