Ensure InsertStrategy.NAME is identical after pickle round-trip #7138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Circuit.insert` uses identity to determine the `InsertStrategy` kind. Here we make InsertStrategy.NAME to get restored to the same object after pickle-unpickle round trip. This should prevent unexpected behavior if `cirq.Insert` is used in a multiprocessing call.
daxfohl
approved these changes
Mar 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7138 +/- ##
==========================================
- Coverage 98.16% 98.15% -0.01%
==========================================
Files 1093 1093
Lines 95523 95536 +13
==========================================
+ Hits 93767 93777 +10
- Misses 1756 1759 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhucka
approved these changes
Mar 12, 2025
BichengYing
pushed a commit
to BichengYing/Cirq
that referenced
this pull request
Jun 20, 2025
…tumlib#7138) The `Circuit.insert` uses identity to determine the `InsertStrategy` kind. Here we make InsertStrategy.NAME to get restored to the same object after pickle-unpickle round trip. This should prevent unexpected behavior if `cirq.Insert` is used in a multiprocessing call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Circuit.insertuses identity to determine theInsertStrategykind.Here we ensure that
InsertStrategy.NAMEis restored to the same objectafter pickle-unpickle round trip. This should prevent unexpected
behavior if
cirq.Insertis used in a multiprocessing call.