Skip to content

Make implicit Optional type hints in Quantum Engine PEP 484 compliant #6640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Make implicit Optional type hints in Quantum Engine PEP 484 compliant #6640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
188e6f5
implicit optional type hints PEP 484 compliant
senecameeks Jun 7, 2024
d375412
rm type ignore
senecameeks Jun 7, 2024
d14a60d
add type ignore back
senecameeks Jun 7, 2024
db0b9fa
mypy
senecameeks Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...google/cirq_google/cloud/quantum_v1alpha1/services/quantum_engine_service/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
from google.api_core import gapic_v1
from google.api_core import retry as retries
from google.auth import credentials as ga_credentials
from google.oauth2 import service_account # type: ignore
from google.oauth2 import service_account

try:
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
Expand Down Expand Up @@ -172,7 +172,7 @@ def transport(self) -> QuantumEngineServiceTransport:
def __init__(
self,
*,
credentials: ga_credentials.Credentials = None,
credentials: Optional[ga_credentials.Credentials] = None,
transport: Union[str, QuantumEngineServiceTransport] = "grpc_asyncio",
client_options: Optional[ClientOptions] = None,
client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
Expand Down
2 changes: 1 addition & 1 deletion cirq-google/cirq_google/cloud/quantum_v1alpha1/services/quantum_engine_service/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
from google.auth.transport import mtls
from google.auth.transport.grpc import SslCredentials
from google.auth.exceptions import MutualTLSChannelError
from google.oauth2 import service_account # type: ignore
from google.oauth2 import service_account

try:
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
Expand Down
4 changes: 2 additions & 2 deletions ...gle/cirq_google/cloud/quantum_v1alpha1/services/quantum_engine_service/transports/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from google.api_core import gapic_v1
from google.api_core import retry as retries
from google.auth import credentials as ga_credentials
from google.oauth2 import service_account # type: ignore
from google.oauth2 import service_account

from cirq_google.cloud.quantum_v1alpha1.types import engine
from cirq_google.cloud.quantum_v1alpha1.types import quantum
Expand All @@ -48,7 +48,7 @@ def __init__(
self,
*,
host: str = DEFAULT_HOST,
credentials: ga_credentials.Credentials = None,
credentials: Optional[ga_credentials.Credentials] = None,
credentials_file: Optional[str] = None,
scopes: Optional[Sequence[str]] = None,
quota_project_id: Optional[str] = None,
Expand Down
2 changes: 1 addition & 1 deletion ...gle/cirq_google/cloud/quantum_v1alpha1/services/quantum_engine_service/transports/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def __init__(

if channel:
# Ignore credentials if a channel was passed.
credentials = False
credentials = None
# If a channel was explicitly provided, set it.
self._grpc_channel = channel
self._ssl_channel_credentials = None
Expand Down
6 changes: 3 additions & 3 deletions ..._google/cloud/quantum_v1alpha1/services/quantum_engine_service/transports/grpc_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class QuantumEngineServiceGrpcAsyncIOTransport(QuantumEngineServiceTransport):
def create_channel(
cls,
host: str = 'quantum.googleapis.com',
credentials: ga_credentials.Credentials = None,
credentials: Optional[ga_credentials.Credentials] = None,
credentials_file: Optional[str] = None,
scopes: Optional[Sequence[str]] = None,
quota_project_id: Optional[str] = None,
Expand Down Expand Up @@ -94,7 +94,7 @@ def __init__(
self,
*,
host: str = 'quantum.googleapis.com',
credentials: ga_credentials.Credentials = None,
credentials: Optional[ga_credentials.Credentials] = None,
credentials_file: Optional[str] = None,
scopes: Optional[Sequence[str]] = None,
channel: Optional[aio.Channel] = None,
Expand Down Expand Up @@ -166,7 +166,7 @@ def __init__(

if channel:
# Ignore credentials if a channel was passed.
credentials = False
credentials = None
# If a channel was explicitly provided, set it.
self._grpc_channel = channel
self._ssl_channel_credentials = None
Expand Down