- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.1k
 
          Add attrs lower bound in requirements.txt
          #6633
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this breaks the pip dependency resolver and the ci tests even whilst uv pip compile dev_tools/requirements/dev.env.txt can find a viable set of packages.
Installation of cirq-core to a fresh virtual environment brings in the latest attrs-23.2.0.
Installation of the whole cirq suite brings attrs-21.4.0 - both of these cases satisfy the required minimum version.
I suggest to hold this for later until after the merge of #6281 which will loosen the maximum attrs version from a transitive dependency.
| 
           I don't see how   | 
    
| 
           @NoureldinYosri, see the   | 
    
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #6633      +/-   ##
==========================================
- Coverage   97.81%   97.81%   -0.01%     
==========================================
  Files        1067     1066       -1     
  Lines       91547    91693     +146     
==========================================
+ Hits        89546    89687     +141     
- Misses       2001     2006       +5     ☔ View full report in Codecov by Sentry.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Require attrs>=21.3.0 to ensure `import attrs` works.
Require attrs>=21.3.0 to ensure `import attrs` works.
Require attrs>=21.3.0 to ensure `import attrs` works.
Require attrs>=21.3.0 to ensure `import attrs` works.
Require attrs>=21.3.0 to ensure `import attrs` works.
Require attrs>=21.3.0 to ensure `import attrs` works.
Require attrs>=21.3.0 to ensure `import attrs` works.
Any
attrs<21.3.0fails for me when I try toimport cirq. And anyattrs>=21.3.0seems to work.Reference: