Merge serializable_forms and deserialized_forms #6520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the experience of updating the supported gateset for
GridDevice.The original reasons of separating of
serializable_formsanddeserialized_formswere twofolds:FSimGateFamily(gates_to_accept=[cirq.CZ])does not acceptcirq.GateFamily(cirq.CZ), and similarly for other 2q gates.FSimGateFamily(gates_to_accept=[cirq.CZ])andcirq.GateFamily(cirq.CZ)were considered redundant for accepting the CZ gate).cirq.PhasedXZGateinstead ofcirq.GateFamily(cirq.PhasedXZGate)).I prefer to merge these fields now because
cirq.GateFamily(cirq.CZ)shouldn't be accepted by the gateset. Although rare, I don't think this is what we want.cc @wcourtney