Skip to content

Remote problematic terminology from test #6368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Remote problematic terminology from test #6368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cirq-core/cirq/protocols/json_serialization_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def test_not_yet_serializable_no_superfluous(mod_spec: ModuleJsonTestSpec):


@pytest.mark.parametrize('mod_spec', MODULE_TEST_SPECS, ids=repr)
def test_mutually_exclusive_blacklist(mod_spec: ModuleJsonTestSpec):
def test_mutually_exclusive_lists(mod_spec: ModuleJsonTestSpec):
Copy link
Collaborator

@viathor viathor Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: blocklist and passlist are self-explanatory alternatives.

Copy link
Collaborator Author

@dstrain115 dstrain115 Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I didn't think that these were necessary. Should not serialize and not yet serialize I guess are block lists, but the term didn't really seem to fit.

common = set(mod_spec.should_not_be_serialized) & set(mod_spec.not_yet_serializable)
assert len(common) == 0, (
f"Defined in both {mod_spec.name} 'Not yet serializable' "
Expand Down