Reject formulas as keys of ParamResolvers #5384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A ParamResolver resolves variables into values. - Having non-trivial formulas as keys allows a significant complexity and ambiguity into ParamResolvers, since it is unclear how much is supported. Prevent this case altogether by raising an error if non-symbol formulas are used in ParamResolvers. Fixes: quantumlib#3550
95-martin-orion
added
the
BREAKING CHANGE
95-martin-orion
approved these changes
May 20, 2022
Collaborator
95-martin-orion
left a comment
95-martin-orion
left a comment
There was a problem hiding this comment.
Hey, I remember writing this issue!
Approved, but marked as BREAKING_CHANGE since this does cut some (possibly unintended) functionality of ParamResolver.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Reject formulas as keys of ParamResolvers - A ParamResolver resolves variables into values. - Having non-trivial formulas as keys allows a significant complexity and ambiguity into ParamResolvers, since it is unclear how much is supported. Prevent this case altogether by raising an error if non-symbol formulas are used in ParamResolvers. Fixes: quantumlib#3550
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Reject formulas as keys of ParamResolvers - A ParamResolver resolves variables into values. - Having non-trivial formulas as keys allows a significant complexity and ambiguity into ParamResolvers, since it is unclear how much is supported. Prevent this case altogether by raising an error if non-symbol formulas are used in ParamResolvers. Fixes: quantumlib#3550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complexity and ambiguity into ParamResolvers, since it is
unclear how much is supported. Prevent this case altogether
by raising an error if non-symbol formulas are used in ParamResolvers.
Fixes: #3550