Skip to content

Conversation

@lightninglu10
Copy link
Contributor

@lightninglu10 lightninglu10 commented Jun 17, 2025

Copy update-major-tag workflow to build branch publish directory

This PR ensures the update-major-tag workflow is included when deploying to the build branch.

Key Changes:

  • Creates .github/workflows directory in the publish folder.
  • Copies update-major-tag.yml into the publish workflows directory.
  • Adds an inline comment clarifying the new step.

Review Notes:

  • Verify that the publish path structure matches expectations.
  • Confirm that the workflow is triggered correctly on the build branch.

@lightninglu10 lightninglu10 self-assigned this Jun 17, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️ CodePress Review Summary

👋 Hey team,

Overall the changes look great! I left 1 helpful note inline.

Here's the quick rundown:

✅ Decision: APPROVE
Simple CI configuration update with minimal risk; changes are clear and easy to revert if needed.

ℹ️ Other thoughts

The reviewers provided minor stylistic suggestions aimed at improving clarity and precision in comments and documentation. These nits emphasize writing concise, action-oriented descriptions to make intentions immediately clear, such as specifying file copy operations directly. While these recommendations do not affect functionality, they enhance readability and maintainability across the codebase.

cp -r dist/ publish/
cp action.yml publish/
cp README.md publish/
# Only copy the update-major-tag workflow to the build branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 NIT: The comment could be more concise and specific. For example, “Copy update-major-tag.yml into publish/.github/workflows” directly describes the action being performed.

Suggested change
# Only copy the update-major-tag workflow to the build branch
# Copy update-major-tag.yml into publish/.github/workflows

@lightninglu10 lightninglu10 merged commit d6d921c into main Jun 17, 2025
4 checks passed
@lightninglu10 lightninglu10 deleted the build-workflow branch June 17, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants