-
Notifications
You must be signed in to change notification settings - Fork 34
moved libraries #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved libraries #93
Conversation
|
@superplay1 Please provide a regex replace command to update the script files. |
The standard practice is to use deprecation warnings and not make API breaking changes without a buffer release in between. For example, if we are now in |
|
Should we use this PR as an example to implement the best practices you just described? |
Semver suggests that after a public API is released (Ver >= 1.x) API breaking changes should trigger major version increment. i.e. 1.2.2 -> 2.0.0-dev |
From what I understand, for all practical purposes our current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just provide the requested search replace expressions, e.g.
c3.system.model -> c3.model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Probably need to provide the search replace command as requested by @fedroy. You can just add it to the description of this PR.
why: cleaner structure
what: restructured model,chip,task
how: moved model.py one layer up, moved chip.py, tasks.py in libraries and modified imports