Skip to content

Conversation

@lazyoracle
Copy link
Member

Example Notebooks must be checked for every PR. The notebooks are typically the first point of entry for anyone using the code-base and it is not uncommon for the notebooks to go out of date (and become malfunctioning) when some breaking changes are introduced in the code.

@lazyoracle lazyoracle added the documentation Improvements or additions to documentation label Jan 22, 2021
@lazyoracle lazyoracle added this to the release/1.2 milestone Jan 22, 2021
@lazyoracle lazyoracle self-assigned this Jan 22, 2021
@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #20 (591c7a8) into dev (bc2f66a) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #20      +/-   ##
==========================================
- Coverage   46.95%   46.81%   -0.15%     
==========================================
  Files          35       35              
  Lines        4453     4398      -55     
==========================================
- Hits         2091     2059      -32     
+ Misses       2362     2339      -23     
Impacted Files Coverage Δ
c3/libraries/envelopes.py 27.77% <0.00%> (-9.58%) ⬇️
c3/libraries/hamiltonians.py 86.48% <0.00%> (-2.41%) ⬇️
c3/libraries/fidelities.py 18.03% <0.00%> (-0.26%) ⬇️
c3/utils/tf_utils.py 44.20% <0.00%> (-0.24%) ⬇️
c3/libraries/sampling.py 0.00% <0.00%> (ø)
c3/libraries/estimators.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2f66a...591c7a8. Read the comment docs.

@lazyoracle
Copy link
Member Author

The Notebook Test check fails (expectedly) because of #19. Putting this PR on hold until that is resolved.

@lazyoracle lazyoracle added the on-hold Currently on hold due to dependencies elsewhere label Jan 22, 2021
@lazyoracle lazyoracle requested review from fedroy and nwittler January 29, 2021 16:05
@lazyoracle lazyoracle removed this from the release/1.2 milestone Jan 29, 2021
@lazyoracle lazyoracle marked this pull request as draft January 29, 2021 18:08
@lazyoracle lazyoracle added this to the 1.2.1 milestone Jan 30, 2021
@lazyoracle lazyoracle marked this pull request as ready for review February 2, 2021 17:54
@lazyoracle lazyoracle added enhancement New feature or request and removed on-hold Currently on hold due to dependencies elsewhere labels Feb 2, 2021
@lazyoracle lazyoracle merged commit 9da32ed into q-optimize:dev Feb 2, 2021
@lazyoracle lazyoracle deleted the notebook-check branch February 2, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants